-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add validation to ResourceFlavor and consider references to ClusterQueue #280
Add validation to ResourceFlavor and consider references to ClusterQueue #280
Conversation
Welcome @xiaoxubeii! |
Hi @xiaoxubeii. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: xiaoxubeii The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
k8s.io/apimachinery v0.23.4 | ||
k8s.io/client-go v0.23.4 | ||
k8s.io/component-base v0.23.3 | ||
k8s.io/api v0.24.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have special reasons to update the dependences?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need PR kubernetes-sigs/controller-runtime#1765 to fix delete validation error in ClusterQueue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am concerned that this will introduce a major bump in the overall project. right now we have 1.22 in the docs as the minimum dependency. and users running v0.1 and v0.1.1 will expect this to be true at least for a couple more versions. so raising the bar to 1.24 before V0.2 is not a viable option IMO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, maybe I can first remove the codes that depends on controller-runtime master and wait until upgrade later.
7bd26e3
to
e18ccd8
Compare
…r ResourceFlavor to prevent data inconsistencies during Quota in ClusterQueue.
e18ccd8
to
d77ef1a
Compare
@xiaoxubeii: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold |
@xiaoxubeii: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
As per discussion in #167 (comment), we are leaving this kind of validation for later. However, I don't think we want to maintain the list of ClusterQueues in the ResourceFlavor object. We should probably just check in a webhook for ClusterQueue. /close Feel free to work on this once we have figured if #167 can be implemented as discussed in #167 (comment) |
@alculquicondor: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add validation of updates to ClusterQueue references for ResourceFlavor to prevent data inconsistencies during Quota in ClusterQueue.
Which issue(s) this PR fixes:
Fixes #167
Special notes for your reviewer: